hotspot: fix intrinsic String.indexOf #54
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanyangjing
force-pushed
the
fix-string_indexOfChar-intrinsic
branch
from
bd83315 to
c97803b
Compare
luchsh
reviewed
Sep 15, 2025
| #endif | ||
| break; | ||
| case Op_StrEquals: | ||
| // We already know that cnt1 == cnt2 here (checked in 'inline_string_equals'). |
There was a problem hiding this comment.
- caller 里是不是也要改一下？
LibraryCallKit::inline_string_equals - 这里每一个分支都有个
#if, 直接拆成两个 switch 是不是可读性更高些
#if
switch (...) {
....
There was a problem hiding this comment.
- caller 里是不是也要改一下？
LibraryCallKit::inline_string_equals- 这里每一个分支都有个
#if, 直接拆成两个 switch 是不是可读性更高些#if switch (...) { ....
Fixed, 考虑到函数开头还有assert，把整个函数都提取成了两个版本。感觉需要等到这里的修复提交后再跑下测试再合入
There was a problem hiding this comment.
对了，能加个测试验证下这个改动吗?
加了String.contains的测试，inline_string_equals加了unreachable
duanyangjing
force-pushed
the
fix-string_indexOfChar-intrinsic
branch
from
c97803b to
8d66fe6
Compare
duanyangjing
changed the title
duanyangjing
changed the title
duanyangjing
changed the title
duanyangjing
force-pushed
the
fix-string_indexOfChar-intrinsic
branch
2 times, most recently
from
b42ea4b to
387f20a
Compare
luchsh
requested changes
Sep 23, 2025
|
|
||
| virtual bool depends_only_on_test() const { return false; } | ||
| virtual const TypePtr* adr_type() const { return TypeAryPtr::BYTES; } | ||
| virtual const TypePtr* adr_type() const { return TypeAryPtr::CHARS; } |
There was a problem hiding this comment.
#if TARGET_CLASSLIB == 8
virtual const TypePtr* adr_type() const { return TypeAryPtr::CHARS; }
#else
virtual const TypePtr* adr_type() const { return TypeAryPtr::BYTES; }
#endif
387f20a to
5b2016e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.